Changeset 468 for Dev/trunk/src/server/util/q-request.js

Timestamp:

06/26/13 21:17:41 (12 years ago)

Author:

hendrikvanantwerpen

Message:

Improved authentication

• Authentication cannot be cancelled, removing a lot of weird race conditions.
• We offer a request provider that has automatic retry in case of authentication failures.
• Reduced dependency on LoginDialog? by having it act independent based on events. Other modules can just depend on 'session'.

File:

• Dev/trunk/src/server/util/q-request.js (moved) (moved from Dev/trunk/src/server/util/request.js) (1 diff)

Dev/trunk/src/server/util/q-request.js

@@ -1 @@
-var http = require('q-io/http'),
+var q = require('q'),
+    request = require('request'),
     url = require('url'),
     _ = require('underscore');
 
-module.exports = function(urlOrObject, options) {
+module.exports = function(url, options) {
 
+    var dfd = q.defer();
+    dfd.response = q.defer();
+    
     options = options
         ? _.clone(options)
         : {};
-    options.url = _.isString(urlOrObject)
-        ? url.parse(urlOrObject)
-        : _.clone(urlOrObject);
+    options.uri = url || options.uri;
+    
+    request(options,function(err,res,body){
+        if ( err ) {
+            dfd.response.reject(err);
+        } else {
+            if ( res.statusCode >= 200 && res.statusCode < 300 ) {
+                dfd.resolve(body);
+            } else {
+                dfd.reject(body);
+            }
+        }
+        dfd.response.resolve(res);
+    });
 
-    // wrap content into q-io thingy
-    if ( options.body ) {
-        options.body = {
-            forEach: function(callback) {
-                callback(JSON.stringify(options.body));
-            }
-        };
-    };
+    return dfd.promise;
     
-    // add auth header since q-io doesn't support this
-    if ( options.url.auth ) {
-        options.headers.authorization = 'Basic '+(new Buffer(options.url.auth).toString("base64"));
-    }
-    
-    // make request and collect results
-    return http.request(options)
-    .then(function(res){
-        return res.body.read().then(function(content){
-            return content.length > 0 ? JSON.parse(content) : null;
-        });
-    },function(res){
-        return res.body.read().then(function(error){
-            return error.length > 0 ? JSON.parse(error) : null;
-        });
-    });
 };