Changeset 496

Timestamp:

03/10/14 01:05:22 (11 years ago)

Author:

hendrikvanantwerpen

Message:

Reject surveys with duplicate questions.

File:

• Dev/trunk/src/server/app.js (modified) (3 diffs)

Dev/trunk/src/server/app.js

@@ -502 +502 @@
 
     // Surveys
+    function areSurveyQuestionsUnique(survey) {
+        return _.chain(survey.questions)
+                .map(function(q){ return q.code; })
+                .uniq()
+                .value().length === survey.questions.length;
+    }
     app.get('/api/surveys',
         ensureAuthenticated,
@@ -527 +533 @@
         ensureAuthenticated,
         ensureMIME(JSON_MIME),
-        makeDocPost('Survey'));
+        function(req,res) {
+            var doc = req.body;
+            var hr;
+            if ( !areSurveyQuestionsUnique(doc) ) {
+                hr = new HTTPResult(400,{error:"Survey contains duplicate questions."});
+            } else {
+                hr = postDocument('Survey',doc);
+            }
+            hr.handle(res.send.bind(res));
+        });
     app.get('/api/surveys/:id',
         ensureAuthenticated,
@@ -535 +550 @@
         ensureAuthenticated,
         ensureMIME(JSON_MIME),
-        makeDocPut_id('Survey'));
+        function(req,res) {
+            var id = req.params.id;
+            var doc = req.body;
+            var rev = etags.parse(req.header('If-Match'))[0] || (doc && doc._rev);
+            var hr;
+            if ( !areSurveyQuestionsUnique(doc) ) {
+                new HTTPResult(400,{error:"Survey contains duplicate questions."})
+                .handle(res.send.bind(res));
+            } else {
+                putDocument(id,rev,'Survey',doc)
+                .handle({
+                    201: function(doc) {
+                        res.set({
+                            'ETag': etags.format([doc._rev])
+                        }).send(201, doc);
+                    },
+                    default: res.send.bind(res)
+                });
+            }
+        });
     app.delete('/api/surveys/:id',
         ensureAuthenticated,