Changeset 500

Timestamp:

03/10/14 16:07:00 (11 years ago)

Author:

hendrikvanantwerpen

Message:

• Indicate of refresh is due to load or due to save in _ObjectPage.
• _ComplexValueMixin & ListWidget? catch all change events and drops them if still being created.

Location:

Dev/trunk/src/client/qed-client

Files:

• model/widgets/QuestionEditorPreviewItem.js (modified) (5 diffs)
• model/widgets/questions/MultipleChoiceInputWidget.js (modified) (1 diff)
• model/widgets/templates/QuestionEditorPreviewItem.html (modified) (2 diffs)
• pages/_ObjectPage.js (modified) (1 diff)
• pages/question.js (modified) (2 diffs)
• pages/survey.js (modified) (3 diffs)
• pages/surveyRun.js (modified) (2 diffs)
• widgets/ListWidget.js (modified) (5 diffs)
• widgets/_ComplexValueMixin.js (modified) (4 diffs)

Dev/trunk/src/client/qed-client/model/widgets/QuestionEditorPreviewItem.js

@@ -1 +1 @@
 define([
+    "../../widgets/_ComplexValueWidget",
     "./questions/Factory",
     "dijit/_Container",
@@ -14 +15 @@
     "dojo/on",
     "dojo/text!./templates/QuestionEditorPreviewItem.html"
-], function(QuestionWidgetFactory, _Container, _TemplatedMixin, _WidgetBase, _WidgetsInTemplateMixin, declare, event, fx, lang, domClass, domGeom, domStyle, on, template) {
-    return declare([_WidgetBase, _TemplatedMixin, _WidgetsInTemplateMixin, _Container], {
+], function(_ComplexValueWidget, QuestionWidgetFactory, _Container, _TemplatedMixin, _WidgetBase, _WidgetsInTemplateMixin, declare, event, fx, lang, domClass, domGeom, domStyle, on, template) {
+    return declare([_ComplexValueWidget], {
         templateString: template,
         baseClass: "qedQuestionEditorPreviewItem",
@@ -87 +88 @@
                 this._destroyInnerWidget();
                 this.innerWidget = newWidget;
-                this.innerWidget.placeAt(this.containerNode);
-                this.innerWidget.startup();
+                this.addChild(this.innerWidget);
                 this.innerWidget.set('readOnly',true);
                 this.titleNode.innerHTML = this.value.type+" [preview]";
@@ -101 +101 @@
                 this._destroyInnerWidget();
                 this.innerWidget = newWidget;
-                this.innerWidget.placeAt(this.containerNode);
-                this.innerWidget.startup();
+                this.addChild(this.innerWidget);
                 this.titleNode.innerHTML = this.value.type+" [editing]";
                 domClass.replace(this.editButton.iconNode, "rftIconAccept", "rftIconEdit");
@@ -111 +110 @@
         _destroyInnerWidget: function() {
             if ( this.innerWidget !== null ) {
+                this.removeChild(this.innerWidget);
                 this.innerWidget.destroyRecursive();
+                this.innerWidget = null;
             }
         },

Dev/trunk/src/client/qed-client/model/widgets/questions/MultipleChoiceInputWidget.js

@@ -32 +32 @@
         _getValueAttr: function() {
             var value = this.inherited(arguments);
-            if ( this.allowMultiple === true ) {
+            /*if ( this.allowMultiple === true ) {
                 return value;
             } else {
-                return value.choice.length > 0;
-            }
+                return value.choice; //.length > 0;
+            }*/
         },
         _setValueAttr: function(value) {

Dev/trunk/src/client/qed-client/model/widgets/templates/QuestionEditorPreviewItem.html

@@ -1 @@
-<div>
+<form>
         <div class="topBorder inheritBgColor bg dojoDndHandle">
                 <span class="title" data-dojo-attach-point="titleNode">Default title</span>
@@ -13 +13 @@
                 </div>
         </div>
-</div>
+</form>

Dev/trunk/src/client/qed-client/pages/_ObjectPage.js

@@ -22 +22 @@
         _load: function() {
             if ( this.object ) {
-                this._refresh();
+                this._refresh(true);
             } else if ( this.objectId ) {
                 if ( this.objectId === "new" ) {
                     this.object = this.classStore.create();
-                    this._refresh();
+                    this.markDirty();
+                    this._refresh(true);
                 } else {
                     this.classStore.load(this.objectId)
-                    .then(lang.hitch(this,'_setObject'),
-                          lang.hitch(this,function(err){
-                                this.die(err.error);
-                            }));
+                    .then(lang.hitch(this,function(object){
+                        this._setObject(object,true);
+                    }),lang.hitch(this,function(err){
+                        this.die(err.error);
+                    }));
                 }
             } else {
-                this.die("No valid uid or object passed!");
+                this.die("No valid id or object passed!");
             }
         },
-        _setObject: function(object) {
+        _setObject: function(object,initial) {
             this.object = object;
             if ( this.objectId === "new" ) {
                 this.go(this.classStore.getObjectPath(this.object),{},true);
             }
-            this._refresh();
+            this.markClean();
+            this._refresh(initial);
         },
-        _refresh: function() {},
+        _refresh: function(initial) {},
         _save: function() {
             return this.classStore.save(this.object)
             .then(lang.hitch(this,function(object){
-                this.markClean();
                 this._setObject(object);
                 this.notify(this.classStore.getName()+" successfully saved.");

Dev/trunk/src/client/qed-client/pages/question.js

@@ -23 +23 @@
             this._load();
         },
-        _refresh: function() {
-            this.propertiesForm.set('value',this.object,null);
-            this.contentList.set('value',this.object.content,null);
-            this._internalRefresh();
-        },
-        _internalRefresh: function(){
+        _refresh: function(initial) {
+            if ( initial === true ) {
+                this.propertiesForm.set('value',this.object,null);
+                this.contentList.set('value',this.object.content,null);
+            }
             this.titleNode.innerHTML = this.object.title || "";
         },
@@ -34 +33 @@
             this._updateObject();
             this.markDirty();
-            this._internalRefresh();
+            this._refresh();
         },
         _handleContentChange: function() {
             this._updateObject();
             this.markDirty();
-            this._internalRefresh();
+            this._refresh();
         },
         _updateObject: function() {

Dev/trunk/src/client/qed-client/pages/survey.js

@@ -61 +61 @@
             this.questionList.startup();
         },
-        _refresh: function() {
-            this.propertiesForm.set('value',{survey:this.object},null);
-            this.questionList.set('value',this.object.questions,null);
-            this._internalRefresh();
-        },
-        _internalRefresh: function() {
+        _refresh: function(initial) {
+            if ( initial === true ) {
+                this.propertiesForm.set('value',{survey:this.object},null);
+                this.questionList.set('value',this.object.questions,null);
+            }
             this.titleNode.innerHTML = this.object.title || "(set title in properties)";
         },
@@ -75 +74 @@
             this.object.questions = this.questionList.get('value');
             this.markDirty();
-            this._internalRefresh();
+            this._refresh();
         },
         _onShowProperties: function(evt) {
@@ -86 +85 @@
             lang.mixin(this.object, this.propertiesForm.get('value').survey);
             this.markDirty();
-            this._internalRefresh();
+            this._refresh();
             if ( evt ) { event.stop(evt); }
             return false;

Dev/trunk/src/client/qed-client/pages/surveyRun.js

@@ -29 +29 @@
             this._load();
         },
-        _refresh: function() {
-            this.surveySummaryWidget.set('value',this.object.survey,null);
-            this.surveyRunWidget.set('value',this.object,null);
-            this._internalRefresh();
-            this._loadResponses();
-        },
-        _internalRefresh: function() {
+        _refresh: function(initial) {
+            if ( initial === true ) {
+                this.surveySummaryWidget.set('value',this.object.survey,null);
+                this.surveyRunWidget.set('value',this.object,null);
+                this._loadResponses();
+            }
             this.titleNode.innerHTML = this.object.title || "";
             if ( this.object.mode === "open" ) {
@@ -77 +76 @@
             this._updateObject();
             this.markDirty();
-            this._internalRefresh();
+            this._refresh();
         },
         _buildGeneralURL: function(surveyRun) {

Dev/trunk/src/client/qed-client/widgets/ListWidget.js

@@ -14 +14 @@
         name: "",
         value: null,
+        disabled: false,
+        readOnly: false,
         multiple: true,
         type: "text",
@@ -20 +22 @@
          */
         container: Source,
+        _onChangeActive: false,
         buildRendering: function() {
             this.inherited(arguments);
@@ -50 +53 @@
             });
             this.source = new this.container(this.domNode,sourceParams);
-            this.own(this.source.on('Drop',lang.hitch(this,'_handleChange')));
+            this.own(this.source.on('Drop',
+                                    lang.hitch(this,'_handleDrop')));
+            this.own(on(this.domNode,'change',
+                        lang.hitch(this,'_handleChange')));
         },
         creator: function(item, hint) {
@@ -92 +98 @@
             return this.value;
         },
-        _setValueAttr: function(value) {
+        _setValueAttr: function(value,priorityChange) {
             this.clear();
             this.appendItems(value || []);
@@ -158 +164 @@
             this.inherited(arguments);
         },
-        _handleChange: function() {
-            this.value = this._getValueAttr();
-            this.onChange(this.value);
+        _handleChange: function(evt) {
+            if ( evt.target !== this.domNode ) {
+                if ( this._onChangeActive && !(this.readOnly || this.disabled) ) {
+                    this.emit('change',this.get('value'));
+                }
+                if ( evt ) { event.stop(evt); }
+                return false;
+            }
+            return true;
         },
-        onChange: function(value) {}
+        _handleDrop: function() {
+            if ( this._onChangeActive && !(this.readOnly || this.disabled) ) {
+                this.emit('change',this.get('value'));
+            }
+        }
     });
 });

Dev/trunk/src/client/qed-client/widgets/_ComplexValueMixin.js

@@ -11 +11 @@
     return declare([_Container, _FormMixin], {
         name: "",
+        value: null,
         disabled: false,
         readOnly: false,
-        _changeActive: false,
+        _onChangeActive: false,
+        constructor: function() {
+            this._listenerMap = {};
+        },
+        buildRendering: function() {
+            // capture child change events
+            this.inherited(arguments);
+            this.own(on(this.domNode,'change',
+                        lang.hitch(this,'_handleChange')));
+        },
+        create: function() {
+            this.inherited(arguments);
+            this._onChangeActive = true;
+        },
         postCreate: function() {
             this.inherited(arguments);
@@ -24 +38 @@
             if (this._started) { return; }
             this.inherited(arguments);
-            this._connectChildren();
-            this._changeActive = true;
-        },
-        _connectChildren: function() {
-            var children = this._getDescendantFormWidgets();
-            array.forEach(children, lang.hitch(this,function(child) {
-                this.own(child.on('change',lang.hitch(this,'_handleChange')));
-            }));
         },
         _setDisabledAttr: function(value) {
@@ -41 +47 @@
         // Yuk, this function is taken directly from _FromMixin only
         // to add the priorityChange parameter
+        _getValueAttr: function() {
+            this.value = this.inherited(arguments);
+            return this.value;
+        },
                 _setValueAttr: function(obj, priorityChange) {
+            this.value = obj;
+
                         var map = { };
                         array.forEach(this._getDescendantFormWidgets(), function(widget){
@@ -84 +96 @@
             }
         },
-        _handleChange: function() {
-            if ( this._changeActive ) {
-                this.onChange(this.get('value'));
+        _handleChange: function(evt) {
+            if ( evt.target !== this.domNode ) {
+                if ( this._onChangeActive && !(this.readOnly || this.disabled) ) {
+                    this.emit('change',this.get('value'));
+                }
+                if ( evt ) { event.stop(evt); }
+                return false;
             }
+            return true;
         },
-        onChange: function(){},
         _handleSubmit: function(evt) {
             var node = this.domNode;