Changeset 502 for Dev

Timestamp:

03/11/14 00:41:43 (11 years ago)

Author:

hendrikvanantwerpen

Message:

• ListWidget? can be disabled/readOnyl now.
• Disable question and survey pages when published.
• Removed weird dialog from survey page and just put a form there. Not very nice, but more consistent with the rest I would say.

Location:

Dev/trunk/src/client/qed-client

Files:

• model/widgets/QuestionEditorToolkit.js (modified) (2 diffs)
• model/widgets/templates/QuestionEditorToolkit.html (modified) (2 diffs)
• pages/question.js (modified) (4 diffs)
• pages/survey.js (modified) (4 diffs)
• pages/templates/question.html (modified) (1 diff)
• pages/templates/survey.html (modified) (1 diff)
• widgets/ListWidget.js (modified) (4 diffs)

Dev/trunk/src/client/qed-client/model/widgets/QuestionEditorToolkit.js

@@ -1 +1 @@
 define([
+    "../../widgets/_ComplexValueWidget",
     "../classes/categories",
     "../classes/topics",
     "./CategoryListView",
-    "dijit/_Container",
-    "dijit/_TemplatedMixin",
-    "dijit/_WidgetBase",
-    "dijit/_WidgetsInTemplateMixin",
     "dijit/form/Button",
     "dijit/form/ComboBox",
@@ -16 +13 @@
     "require",
     "dojo/text!./templates/QuestionEditorToolkit.html"
-], function(categories, topics, CategoryListView, _Container, _TemplatedMixin, _WidgetBase, _WidgetsInTemplateMixin, Button, ComboBox, declare, lang, Source, domConstruct, Memory, require, template) {
-    return declare([_WidgetBase, _TemplatedMixin, _WidgetsInTemplateMixin, _Container], {
+], function(_ComplexValueWidget, categories, topics, CategoryListView, Button, ComboBox, declare, lang, Source, domConstruct, Memory, require, template) {
+    return declare([_ComplexValueWidget], {
 
         contextRequire: require,

Dev/trunk/src/client/qed-client/model/widgets/templates/QuestionEditorToolkit.html

@@ -1 @@
-<div>
+<form>
         <div data-dojo-type="../../widgets/TitleGroup">
                 <div data-dojo-type="dijit/TitlePane" class="orange" data-dojo-props="open:true" title="Properties" data-dojo-props="iconClass:'rftIcon rftIconProperties'">
@@ -23 +23 @@
                 </div>
         </div>
-</div>
+</form>

Dev/trunk/src/client/qed-client/pages/question.js

@@ -13 +13 @@
         contextRequire: require,
         templateString: template,
-        _toolkit: null,
         _preview: null,
         classStore: questions,
@@ -19 +18 @@
             if ( this._started ) { return; }
             this.inherited(arguments);
-            this.own(this.propertiesForm.on('change',lang.hitch(this,'_handlePropertiesChange')));
+            this.own(this.QuestionEditorToolkit.on('change',lang.hitch(this,'_handlePropertiesChange')));
             this.own(this.contentList.on('change',lang.hitch(this,'_handleContentChange')));
             this._load();
@@ -25 +24 @@
         _refresh: function(initial) {
             if ( initial === true ) {
-                this.propertiesForm.set('value',this.object,null);
+                this.QuestionEditorToolkit.set('value',this.object,null);
                 this.contentList.set('value',this.object.content,null);
             }
             this.titleNode.innerHTML = this.object.title || "";
+            if ( this.object.publicationDate ) {
+                this.QuestionEditorToolkit.set('readOnly',true);
+                this.QuestionEditorToolkit.set('disabled',true);
+                this.contentList.set('readOnly',true);
+                this.contentList.set('disabled',true);
+            }
         },
         _handlePropertiesChange: function() {
@@ -41 +46 @@
         },
         _updateObject: function() {
-            var pValid = this.propertiesForm.validate();
-            lang.mixin(this.object,this.propertiesForm.get('value'));
+            var pValid = this.QuestionEditorToolkit.validate();
+            lang.mixin(this.object,this.QuestionEditorToolkit.get('value'));
             var cValid = this.contentList.validate();
             this.object.content = this.contentList.get('value');

Dev/trunk/src/client/qed-client/pages/survey.js

@@ -24 +24 @@
             this._setupListView();
             this.own(this.questionList.on('change',lang.hitch(this,'_handleQuestionsChange')));
+            this.own(this.propertiesForm.on('change',lang.hitch(this,'_handlePropertiesChange')));
             this._load();
         },
@@ -67 +68 @@
             }
             this.titleNode.innerHTML = this.object.title || "(set title in properties)";
+            if ( this.object.publicationDate ) {
+                this.propertiesForm.set('readOnly',true);
+                this.propertiesForm.set('disabled',true);
+                this.questionList.set('readOnly',true);
+                this.questionList.set('disabled',true);
+            }
         },
         _includeQuestion: function(question) {
@@ -76 +83 @@
             this._refresh();
         },
-        _onShowProperties: function(evt) {
-            this.propertiesDialog.show();
-            if ( evt ) { event.stop(evt); }
-            return false;
-        },
-        _onPropertiesOk: function(evt) {
-            this.propertiesDialog.hide();
+        _handlePropertiesChange: function() {
             lang.mixin(this.object, this.propertiesForm.get('value').survey);
             this.markDirty();
             this._refresh();
-            if ( evt ) { event.stop(evt); }
-            return false;
-        },
-        _onPropertiesCancel: function(evt) {
-            this.propertiesDialog.hide();
-            this.propertiesForm.set('value',{survey:this.object});
-            if ( evt ) { event.stop(evt); }
-            return false;
+            this.layout();
         },
         _onSave: function(evt) {
@@ -128 +122 @@
             this.discardBtn.set('label','Close');
             this.inherited(arguments);
+        },
+        _ignore: function(evt) {
+            event.stop(evt);
+            return false;
         }
     });

Dev/trunk/src/client/qed-client/pages/templates/question.html

@@ -6 +6 @@
         </h2>
     </div>
-    <form data-dojo-type="dijit/form/Form"
-         data-dojo-props="region:'left'"
-         data-dojo-attach-point="propertiesForm"
-         data-dojo-attach-event="onSubmit:_ignore">
+    <div data-dojo-type="dijit/layout/ContentPane"
+         data-dojo-props="region:'left'">
         <div data-dojo-type="dijit/layout/BorderContainer" data-dojo-props="design:'headline'" style="width: 300px;">
-            <div data-dojo-type="dijit/layout/ContentPane" data-dojo-props="region:'center'">
-                <div data-dojo-type="../model/widgets/QuestionEditorToolkit"
-                     data-dojo-attach-point="QuestionEditorToolkitNode"></div>
-            </div>
             <div data-dojo-type="dijit/layout/ContentPane" data-dojo-props="region:'top'">
                 <button data-dojo-type="dijit/form/Button"
-                        data-dojo-props="baseClass: 'rftLargeButton', iconClass: 'rftIcon rftIconAccept'"
+                        data-dojo-props="baseClass: 'rftBlockButton', iconClass: 'rftIcon rftIconAccept'"
                         data-dojo-attach-point="saveBtn"
                         data-dojo-attach-event="onClick:_onSave">
                   Save</button>
                 <button data-dojo-type="dijit/form/Button"
-                        data-dojo-props="baseClass: 'rftLargeButton', iconClass: 'rftIcon rftIconAccept'"
+                        data-dojo-props="baseClass: 'rftBlockButton', iconClass: 'rftIcon rftIconAccept'"
                         data-dojo-attach-point="saveAndCloseBtn"
                         data-dojo-attach-event="onClick:_onSaveAndClose">
                   Save &amp; Close</button>
                 <button data-dojo-type="dijit/form/Button"
-                        data-dojo-props="baseClass: 'rftLargeButton', iconClass: 'rftIcon rftIconCancel'"
+                        data-dojo-props="baseClass: 'rftBlockButton', iconClass: 'rftIcon rftIconCancel'"
                         data-dojo-attach-point="discardBtn"
                         data-dojo-attach-event="onClick:_onDiscard">
                   Discard &amp; Close</button>
             </div>
+            <div data-dojo-type="dijit/layout/ContentPane" data-dojo-props="region:'center'">
+                <div data-dojo-type="../model/widgets/QuestionEditorToolkit"
+                     data-dojo-attach-point="QuestionEditorToolkit"></div>
+            </div>
         </div>
-    </form>
+    </div>
     <div data-dojo-type="../model/widgets/QuestionEditorPreview"
          data-dojo-attach-point="contentList"

Dev/trunk/src/client/qed-client/pages/templates/survey.html

@@ -13 +13 @@
     
     <div data-dojo-type="dijit/layout/BorderContainer" data-dojo-props="region:'right'" style="width: 300px">
+      
+        <form data-dojo-type="dijit/form/Form"
+              data-dojo-attach-point="propertiesForm"
+              data-dojo-attach-event="onSubmit:_ignore"
+              data-dojo-props="region:'top'">
+            <fieldset class="qedFieldset">
+                <div data-dojo-type="../model/widgets/SurveyWidget" data-dojo-props="name:'survey'"></div>
+            </fieldset>
+        </form>
+
         <div data-dojo-attach-point="surveyListViewNode" class="rftSurveyListView">
         </div>
 
-        <div data-dojo-type="dijit/layout/ContentPane" data-dojo-props="region: 'bottom'">
-            <button data-dojo-type="dijit/form/Button"
-                    data-dojo-attach-event="onClick:_onShowProperties"
-                    data-dojo-props="baseClass: 'rftLargeButton', iconClass: 'rftIcon rftIconProperties'">
-                Properties</button>
+        <div data-dojo-type="dijit/layout/ContentPane"
+             data-dojo-props="region:'bottom'">
             <button data-dojo-type="dijit/form/Button"
                     data-dojo-attach-event="onClick:_onSave"
                     data-dojo-attach-point="saveBtn"
-                    data-dojo-props="baseClass: 'rftLargeButton', iconClass: 'rftIcon rftIconAccept'">
+                    data-dojo-props="baseClass: 'rftBlockButton', iconClass: 'rftIcon rftIconAccept'">
                 Save</button>
             <button data-dojo-type="dijit/form/Button"
                     data-dojo-attach-event="onClick:_onSaveAndClose"
                     data-dojo-attach-point="saveAndCloseBtn"
-                    data-dojo-props="baseClass: 'rftLargeButton', iconClass: 'rftIcon rftIconAccept'">
+                    data-dojo-props="baseClass: 'rftBlockButton', iconClass: 'rftIcon rftIconAccept'">
                 Save &amp; Close</button>
             <button data-dojo-type="dijit/form/Button"
                     data-dojo-attach-event="onClick:_onDiscardAndClose"
                     data-dojo-attach-point="discardBtn"
-                    data-dojo-props="baseClass: 'rftLargeButton', iconClass: 'rftIcon rftIconCancel'">
+                    data-dojo-props="baseClass: 'rftBlockButton', iconClass: 'rftIcon rftIconCancel'">
                 Discard &amp; Close</button>
             <button data-dojo-type="dijit/form/Button"
                     data-dojo-attach-event="onClick:_onShowPreview"
-                    data-dojo-props="baseClass: 'rftLargeButton', iconClass: 'rftIcon rftIconPreview'">
+                    data-dojo-props="baseClass: 'rftBlockButton', iconClass: 'rftIcon rftIconPreview'">
                 Preview</button>
         </div>
     </div>
 
-    <div data-dojo-type="dijit/Dialog"
-         data-dojo-props="'title':'Survey properties'"
-         data-dojo-attach-point="propertiesDialog">
-        <form data-dojo-type="dijit/form/Form"
-              data-dojo-attach-point="propertiesForm"
-              data-dojo-attach-event="onSubmit:_onPropertiesOk">
-            <fieldset class="qedFieldset">
-                <div data-dojo-type="../model/widgets/SurveyWidget" data-dojo-props="name:'survey'"></div>
-            </fieldset>
-            <button data-dojo-type="dijit/form/Button"
-                    type="submit"
-                    data-dojo-attach-event="onClick:_onPropertiesOk">
-                OK</button>
-            <button data-dojo-type="dijit/form/Button"
-                    type="button"
-                    data-dojo-attach-event="onClick:_onPropertiesCancel">
-                Cancel</button>
-        </form>
-    </div>
-
 </div>

Dev/trunk/src/client/qed-client/widgets/ListWidget.js

@@ -23 +23 @@
          */
         container: Source,
+        _restoreParams: null,
         _onChangeActive: false,
         buildRendering: function() {
@@ -54 +55 @@
             });
             this.source = new this.container(this.domNode,sourceParams);
+            this._restoreParams = {
+                accept: this.source.accept,
+                selfAccept: this.source.selfAccept,
+                selfCopy: this.source.selfCopy,
+                isSource: this.source.isSource
+            };
             this.own(this.source.on('Drop',
                                     lang.hitch(this,'_handleDrop')));
@@ -112 +119 @@
                 child.set("disabled", value);
             });
+            this._updateContainer();
         },
         _setReadOnlyAttr: function(value) {
@@ -118 +126 @@
                 child.set("readOnly", value);
             });
+            this._updateContainer();
+        },
+        _updateContainer: function() {
+            if ( this.disabled || this.readOnly ) {
+                this.source.accept = [];
+                this.source.selfAccept = false;
+                this.source.selfCopy = false;
+                this.source.isSource = false;
+            } else {
+                lang.mixin(this.source,this._restoreParams);
+            }
         },
         focus: function() {