Changeset 186 for Dev/trunk/classes/AnswerSetConnector.php

Timestamp:

12/16/11 11:19:54 (13 years ago)

Author:

jkraaijeveld

Message:

Implemented lazy evaluation.

• Initially, references to other database objects are now given as an ID rather than an object.
• Every model class now has an evaluate() function, which gets all the objects that object has references to. Returns true if it got all the values correctly, false if there are invalid references.
• Every connector now first evaluates an object before storing, to make sure only objects with valid references get stored.

File:

• Dev/trunk/classes/AnswerSetConnector.php (modified) (4 diffs)

Dev/trunk/classes/AnswerSetConnector.php

@@ -50 +50 @@
                         foreach($results as $result)
                         {
-                                $survey = $this->db->get("survey", array("uid" => $result['?for_survey']->label));
-                                $respondent = $this->db->get("respondent", array("uid" => $result['?by_respondent']->label));
+                                $survey = $result['?for_survey']->label;
+                                $respondent = $result['?by_respondent']->label;
                                 $answers =      $this->getAnswers($result['?uid']->label);
                                 $answerSets[] = new AnswerSet($result['?uid']->label, $survey[0], $respondent[0], $answers);
@@ -71 +71 @@
                 {
                         $element = $iterator->next();
-                        $answersR = $this->db->get("answer", array("uid" => $element->getLabelObject()));
-                        $answers[] = $answersR[0];
+                        $answers[] = $element->getLabelObject();
                 }
                 return $answers;
@@ -84 +83 @@
         {
                 $this->load();
+                //If evaluation fails, some references are incorrect.
+                //We shouldn't save in this case. Instead - let the user know. This function returns false if the evaluation has failed.
+                //TODO: Decide how to fix invalid references graciously.
+                if(!$rToolObject->evaluate()) 
+                        return false;
+
                 $resourceAnswerSet = new Resource(ANSWERSET . '/' . $rToolObject->uid);
                 //Remove the old value stored with the given id
@@ -115 +120 @@
                 }
                 $this->save();
+                return true;
         }
 }