Changeset 468 for Dev/trunk/src/client/qed-client/ui/SessionMenu.coffee

Timestamp:

06/26/13 21:17:41 (12 years ago)

Author:

hendrikvanantwerpen

Message:

Improved authentication

• Authentication cannot be cancelled, removing a lot of weird race conditions.
• We offer a request provider that has automatic retry in case of authentication failures.
• Reduced dependency on LoginDialog? by having it act independent based on events. Other modules can just depend on 'session'.

File:

• Dev/trunk/src/client/qed-client/ui/SessionMenu.coffee (modified) (2 diffs)

Dev/trunk/src/client/qed-client/ui/SessionMenu.coffee

@@ -1 +1 @@
 define [
     "../session",
-    "dijit/DropDownMenu",
-    "dijit/registry",
+    "./LoginDialogWrapper",
     "dijit/MenuBarItem",
     "dojo/_base/declare",
     "dojo/_base/event",
     "dojo/on"
-], (session, DropDownMenu, registry, MenuBarItem, declare, event, _on) ->
+], (session, LoginDialogWrapper, MenuBarItem, declare, event, _on) ->
     declare [MenuBarItem],
         info: null
         postCreate: () ->
-            @loginDialog = registry.byId 'loginDialog'
-            console.error "Cannot find loginDialog" if not @loginDialog
             @set 'label', "Login"
         startup: () ->
@@ -29 +26 @@
                 session.logout()
             else
-                @loginDialog.show()
+                LoginDialogWrapper.show()
             event.stop evt if evt
             false